Fix failing tests #421
Merged
Fix failing tests #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjmonson
force-pushed
the
features/refactor/more_unit_tests
branch
3 times, most recently
from
3f0ac0e to
dabe4b6
Compare
Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
sjmonson
force-pushed
the
features/refactor/more_unit_tests
branch
2 times, most recently
from
ba9203f to
64aa2fe
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes failing unit tests across the codebase, with most changes involving updates to reflect API changes in request/response schemas and class renames. Several tests that couldn't be fixed are marked as XFAIL with run=False.
Key changes:
- Updated test code to use new schema names (
RequestInfo,RequestTimingsinstead ofScheduledRequestInfo,MeasuredRequestTimings) - Replaced deprecated/removed classes and methods related to request timing strategies
- Marked unfixable tests with
pytest.mark.xfail(reason="old and broken", run=False)
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/utils/test_text.py | Added XFAIL marker to broken test |
| tests/unit/utils/test_messaging.py | Updated imports and class names from ScheduledRequestInfo to RequestInfo |
| tests/unit/utils/test_encoding.py | Updated imports and class references for renamed schemas |
| tests/unit/testing_utils.py | Fixed logic order in async_timeout decorator |
| tests/unit/test_main.py | Added XFAIL marker to broken test |
| tests/unit/scheduler/test_worker_group.py | Major refactoring to remove deprecated timing registries and update test parameters |
| tests/unit/scheduler/test_worker.py | Updated to use new strategy-based timing instead of separate timing classes |
| tests/unit/scheduler/test_strategies.py | Removed tests for deleted timing classes, inlined calculations |
| tests/unit/scheduler/test_scheduler.py | Updated imports and added missing startup_duration parameters |
| tests/unit/scheduler/test_objects.py | Renamed test classes and updated to new schema names |
| tests/unit/scheduler/test_environment.py | Updated RequestInfo import and usage |
| tests/unit/scheduler/test_constraints.py | Updated RequestInfo import and usage |
| tests/unit/preprocess/test_dataset.py | Added XFAIL markers to broken tests |
| tests/unit/mock_benchmark.py | Updated mock object to use new schema structure |
| tests/unit/mock_backend.py | Updated imports and class usage |
| tests/unit/benchmark/test_output.py | Updated test setup to include required args parameter |
| tests/unit/backends/test_openai_backend.py | Major refactoring to align with new backend API structure |
| tests/unit/backends/test_objects.py | Updated to test new request/response schema structure |
| tests/unit/backends/test_backend.py | Updated to use new schema names |
| src/guidellm/scheduler/init.py | Removed exports for deleted timing classes |
| pyproject.toml | Excluded tests directory from mypy checking |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
sjmonson
force-pushed
the
features/refactor/more_unit_tests
branch
from
64aa2fe to
3add86f
Compare
markurtz
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes tests whenever possible and marks remaining ones as
XFAIL.Test Plan
tox -e test-unittox -e test-integrationtox -e test-unit -- --runxfailUse of AI
## WRITTEN BY AI ##)